Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logger with monolog #614

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jaapio
Copy link
Contributor

@jaapio jaapio commented Sep 24, 2024

The logger introduced before was very usefull in the setup process but by now, it should be replaced by something more mature to ensure the logs to not end up in the final output.

@SenseException
Copy link
Member

This needs a rebase and a conflict needs to be fixed due to one of the past PRs introduced changes to composer.lock. Has anyone used the "Resolve conflicts" button of GitHub? I was quite tempted to use it, but I rather prefer to do such steps in a console.

@greg0ire
Copy link
Member

I remember trying it in the past, but I usually stick to the console, and would certainly do so for composer.lock. That being said, there's a chance @jaapio allows writing to his branch, so you could try fixing it locally. I'll give it a try.

The logger introduced before was very usefull in the setup process
but by now, it should be replaced by something more mature to ensure
the logs to not end up in the final output.
@greg0ire
Copy link
Member

Yup, writable, that's usually the case. I use https://ldez.github.io/prm/ for this, but I think gh also covers this feature.

@SenseException SenseException merged commit 2ca4437 into doctrine:staging Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants