Fix section author markup #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the correct template for section authors. Add an extra fix in the migration from old doc styles to correct the display of author names.
jaapio
force-pushed
the
fix/section-author
branch
from
1bfc054
to
45fc3fa
Compare
greg0ire
reviewed
Sep 24, 2024
| '/.. sectionauthor:: ([^\(]+) \(([^\)]+)\)/', | ||
| '.. sectionauthor:: $1 <$2>', | ||
| $content, | ||
| ); |
There was a problem hiding this comment.
Why is this necessary? Are there docs that don't follow the desired syntax already?
There was a problem hiding this comment.
Yes, some of the old docs to use jaapio ([email protected]) where it should be jaapio <[email protected]>
greg0ire
approved these changes
Sep 24, 2024
SenseException
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the correct template for section authors.
Add an extra fix in the migration from old doc styles to correct the display of author names.
See: https://staging.doctrine-project.org/projects/doctrine-orm/en/3.3/cookbook/implementing-arrayaccess-for-domain-objects.html#implementing-arrayaccess-for-domain-objects