[GH-4257] orphaned foreign key missing guard #4258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
force-pushed
the
GH-4257-OrphanedForeignKeyMissingGuard
branch
2 times, most recently
from
9cd14b6 to
41f7924
Compare
greg0ire
reviewed
Sep 6, 2020
beberlei
force-pushed
the
GH-4257-OrphanedForeignKeyMissingGuard
branch
from
41f7924 to
97b8243
Compare
morozov
reviewed
Sep 6, 2020
morozov
reviewed
Sep 9, 2020
Member
morozov
left a comment
morozov
left a comment
There was a problem hiding this comment.
Looks good. Let’s get it squashed and merged.
…e/drop support on orphaned foreign keys.
beberlei
force-pushed
the
GH-4257-OrphanedForeignKeyMissingGuard
branch
from
f50bbe2 to
80e9f54
Compare
Member
|
Irrelevant as of #4255. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Orphaned foreign keys lead to alter table statement in sqlite, which is not possible. Tables that are targets of foreign keys can be deleted in Sqlite, so skipping this block based on existing platform check works.
Fixes #4257