Update doctrine/coding-standard to 8.1 #4150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 6, 2020
Member
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
It's only dev dependencies so this is ok 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to Coding Standard the 8.0 in #4050, I decided to upgrade only
2.11.xin order to not touch dependencies in2.10.xbut in practice having different coding standards in different supported versions creates extra merge conflicts during up-merges. Furthermore, the coding standard is a development dependency bumping which won't affect the package dependents.