Skip to content

Conversation

@morozov
Copy link
Member

@morozov morozov commented Jul 4, 2020

Q A
Type improvement
BC Break no

In hindsight, the introduction of the DefaultExceptionConverter in #4136 wasn't the best idea. If the drivers that use it implement their own proper logic, this class will become unused but will have to be kept in place. It's better to have one copy with the same logic per driver that could be evolved independently w/o BC concerns.

@morozov morozov added this to the 3.0.0 milestone Jul 5, 2020
@morozov morozov requested a review from greg0ire July 5, 2020 00:42
@morozov morozov marked this pull request as ready for review July 5, 2020 20:06
@morozov morozov merged commit d47d1a4 into doctrine:3.0.x Jul 5, 2020
@morozov morozov deleted the remove-default-exception-converter branch July 5, 2020 20:38
@morozov morozov self-assigned this Jul 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants