Fix a condition that would not allow diffing of foreign keys for Sqlite#4011
Closed
camilleterol wants to merge 35 commits intodoctrine:2.10.xfrom
Closed
Fix a condition that would not allow diffing of foreign keys for Sqlite#4011camilleterol wants to merge 35 commits intodoctrine:2.10.xfrom
camilleterol wants to merge 35 commits intodoctrine:2.10.xfrom
Conversation
Rename andX() / orX() methods
First parameter of ExpressionBuilder::and/or() mandatory
Prepare CompositeExpression for immutability
Deprecate calling QueryBuilder methods with an array argument
Deprecated the usage of the Version class
…eexpression CompositeExpression and()/or() factory methods
Bump version to 2.11.0-DEV
Deprecate the usage of the legacy platforms and drivers
1. Removed no longer existing entries 2. Added new entries 3. Sorted using `sort` (ignores case and the leading dot, same as `ls`)
Removed performance tests
Actualize the content of the .gitattributes file
Deprecate EchoSQLLogger
….11.x_5e9de30c262e49.66926046 Merge release 2.10.2 into 2.11.x
allow using multiple connections for CLI commands
Member
|
This looks a lot like #3994 … maybe there are more occurrences of In any case, please add a test. Also, since this is a patch, you should target 2.10.x IMO. |
Author
|
Thanks for the swift reply. I'll look into adding a test for this specific use case. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the changes introduced by #1204, the SchemaDiff would throw an error when trying to diff an Sqlite-backed schema with foreign keys modifications.