Skip to content

Don't skip a test for sqlite #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Don't skip a test for sqlite #3705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ public function testSyntaxErrorException() : void

public function testConnectionExceptionSqLite() : void
{
if ($this->connection->getDatabasePlatform() instanceof SqlitePlatform) {
if (! ($this->connection->getDatabasePlatform() instanceof SqlitePlatform)) {
$this->markTestSkipped('Only fails this way on sqlite');
}

Expand Down Expand Up @@ -327,7 +327,8 @@ public function testConnectionExceptionSqLite() : void
$table->addColumn('id', 'integer');

$this->expectException(Exception\ReadOnlyException::class);
$this->expectExceptionMessage(<<<EOT
$this->expectExceptionMessage(
<<<EOT
An exception occurred while executing 'CREATE TABLE no_connection (id INTEGER NOT NULL)':

SQLSTATE[HY000]: General error: 8 attempt to write a readonly database
Expand Down