Reworked driver exceptions #3505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 5, 2019
Majkl578
reviewed
Apr 5, 2019
| 2. `Doctrine\DBAL\Driver\PDOException` no longer extends `PDOException`. | ||
| 3. The value returned by `Doctrine\DBAL\Driver\PDOException::getSQLState()` no longer falls back to the driver error code. | ||
|
|
||
| The method was used internally and is no longer needed. |
There was a problem hiding this comment.
This shouldn't be here, looks like a copy&paste error.
There was a problem hiding this comment.
Yes, incorrect conflict resolution. I'll remove it later.
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Reworked driver exceptions
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
May 31, 2019
Reworked driver exceptions
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Aug 26, 2019
Reworked driver exceptions
This was referenced Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the breaking changes necessitated by enforcing strict scalar types and adding return type hints, named constructors were added to
DB2ExceptionandMysqliException.