-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Schemas with views #3233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schemas with views #3233
Conversation
e33d50c to
7256059
Compare
ba974fe to
acb6f9f
Compare
Comparation schemas with views Created ViewVisitor interface Removed unused namespaces
|
@morozov could you review this PR when you will have a little time? At least to set some kind of direction of what should I do next. |
ostrolucky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use parameter and return types everywhere
|
There are still missing typehints, please go through your PR and add it everywhere. I've seen missing |
|
@ostrolucky as far as I can see there is no any return type hints used in code base yet. I will add type hints/return type to methods introduced by me (so there would be no or little conflicts), but I would suggest to add type hints to other methods as part of separate PR. Also, I could try to use psalm/psalter to automatically update typehints in code base from inferred types updated: Looks like @morozov already planning to do something like that: vimeo/psalm#1073 |
Please use all possible type hints for new APIs. No need to update existing code. I'm working on these changes against |
|
@fesor I haven't had a chance to dive deep in the code but on the surface, it all looks good. Please continue to the extent where you consider it code complete and we can get back to it. Or do you have any specific questions? |
Summary
This PR adds ability to define views using schema manager. This is small rework of #2510