Missing type hints in $query, $params, $types sets #3034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Mar 1, 2018
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
Looking good from here, although unsure if this will be a BC break (too little ☕ and toi early in the morning)
Contributor
|
Wouldn't pursue similar changes until develop lands in master, too early in the DBAL 3.0 cycle. |
morozov
force-pushed
the
develop
branch
3 times, most recently
from
7b7cffe to
c5e8a7c
Compare
morozov
force-pushed
the
develop
branch
3 times, most recently
from
fd275f8 to
c78e0e5
Compare
…having to replicate the \PDOStatement interface in ResultStatement
The regression was introduced by 2b8c40d. Fixes doctrine#3060.
Use a wrapped PDO Statement instead of a custom class for `pdo_sqlsrv` since `PDOSqlsrv\Statement` doesn't extend `PDOStatement` anymore.
Contributor
Author
|
Done |
Majkl578
suggested changes
Apr 26, 2018
Contributor
Majkl578
left a comment
Majkl578
left a comment
There was a problem hiding this comment.
I still think we shouldn't do this until develop is merged into master. (Same as fixing CS globally.)
Contributor
Author
|
ping me if needed ;) |
morozov
force-pushed
the
develop
branch
2 times, most recently
from
72cddfb to
d8f1786
Compare
morozov
force-pushed
the
develop
branch
3 times, most recently
from
67bd64c to
7e5fb71
Compare
morozov
force-pushed
the
develop
branch
2 times, most recently
from
c4478a0 to
e5a586e
Compare
morozov
force-pushed
the
develop
branch
2 times, most recently
from
0a11c71 to
fa42c10
Compare
Member
|
superseded with #3348 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.