Inconsistent parameter names

[greg0ire]

Bug Report

Q	A
BC Break	yes/no
Version	x.y.z

Summary

We have signatures that use different names. I want to fix this, but don't know which names are best

ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Driver/DrizzlePDOMySql/Connection.php:13:27 - Argument 1 of Doctrine\DBAL\Driver\DrizzlePDOMySql\Connection::quote has wrong name $value, expecting $input as defined by Doctrine\DBAL\Driver\Connection::quote (see https://psalm.dev/230)
    public function quote($value, $type = ParameterType::STRING)



ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php:129:27 - Argument 1 of Doctrine\DBAL\Driver\OCI8\OCI8Connection::quote has wrong name $value, expecting $input as defined by Doctrine\DBAL\Driver\Connection::quote (see https://psalm.dev/230)
    public function quote($value, $type = ParameterType::STRING)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvConnection.php:101:27 - Argument 1 of Doctrine\DBAL\Driver\SQLSrv\SQLSrvConnection::quote has wrong name $value, expecting $input as defined by Doctrine\DBAL\Driver\Connection::quote (see https://psalm.dev/230)
    public function quote($value, $type = ParameterType::STRING)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/OraclePlatform.php:55:52 - Argument 2 of Doctrine\DBAL\Platforms\OraclePlatform::getSubstringExpression has wrong name $position, expecting $from as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getSubstringExpression (see https://psalm.dev/230)
    public function getSubstringExpression($value, $position, $length = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/OraclePlatform.php:387:43 - Argument 1 of Doctrine\DBAL\Platforms\OraclePlatform::_getCreateTableSQL has wrong name $table, expecting $tableName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::_getCreateTableSQL (see https://psalm.dev/230)
    protected function _getCreateTableSQL($table, array $columns, array $options = [])


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php:1108:47 - Argument 1 of Doctrine\DBAL\Platforms\PostgreSqlPlatform::getEmptyIdentityInsertSQL has wrong name $quotedTableName, expecting $tableName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getEmptyIdentityInsertSQL (see https://psalm.dev/230)
    public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php:1108:65 - Argument 2 of Doctrine\DBAL\Platforms\PostgreSqlPlatform::getEmptyIdentityInsertSQL has wrong name $quotedIdentifierColumnName, expecting $identifierColumnName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getEmptyIdentityInsertSQL (see https://psalm.dev/230)
    public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SQLAnywherePlatform.php:1127:45 - Argument 2 of Doctrine\DBAL\Platforms\SQLAnywherePlatform::getTrimExpression has wrong name $pos, expecting $mode as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getTrimExpression (see https://psalm.dev/230)
    public function getTrimExpression($str, $pos = TrimMode::UNSPECIFIED, $char = false)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php:895:47 - Argument 1 of Doctrine\DBAL\Platforms\SQLServerPlatform::getEmptyIdentityInsertSQL has wrong name $quotedTableName, expecting $tableName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getEmptyIdentityInsertSQL (see https://psalm.dev/230)
    public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php:895:65 - Argument 2 of Doctrine\DBAL\Platforms\SQLServerPlatform::getEmptyIdentityInsertSQL has wrong name $quotedIdentifierColumnName, expecting $identifierColumnName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getEmptyIdentityInsertSQL (see https://psalm.dev/230)
    public function getEmptyIdentityInsertSQL($quotedTableName, $quotedIdentifierColumnName)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php:1071:45 - Argument 2 of Doctrine\DBAL\Platforms\SQLServerPlatform::getTrimExpression has wrong name $pos, expecting $mode as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getTrimExpression (see https://psalm.dev/230)
    public function getTrimExpression($str, $pos = TrimMode::UNSPECIFIED, $char = false)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:81:45 - Argument 2 of Doctrine\DBAL\Platforms\SqlitePlatform::getTrimExpression has wrong name $pos, expecting $mode as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getTrimExpression (see https://psalm.dev/230)
    public function getTrimExpression($str, $pos = TrimMode::UNSPECIFIED, $char = false)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:106:52 - Argument 2 of Doctrine\DBAL\Platforms\SqlitePlatform::getSubstringExpression has wrong name $position, expecting $from as defined by Doctrine\DBAL\Platforms\AbstractPlatform::getSubstringExpression (see https://psalm.dev/230)
    public function getSubstringExpression($value, $position, $length = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:327:43 - Argument 1 of Doctrine\DBAL\Platforms\SqlitePlatform::_getCreateTableSQL has wrong name $name, expecting $tableName as defined by Doctrine\DBAL\Platforms\AbstractPlatform::_getCreateTableSQL (see https://psalm.dev/230)
    protected function _getCreateTableSQL($name, array $columns, array $options = [])


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Portability/Statement.php:116:46 - Argument 2 of Doctrine\DBAL\Portability\Statement::setFetchMode has wrong name $arg1, expecting $arg2 as defined by Doctrine\DBAL\Driver\ResultStatement::setFetchMode (see https://psalm.dev/230)
    public function setFetchMode($fetchMode, $arg1 = null, $arg2 = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Portability/Statement.php:116:60 - Argument 3 of Doctrine\DBAL\Portability\Statement::setFetchMode has wrong name $arg2, expecting $arg3 as defined by Doctrine\DBAL\Driver\ResultStatement::setFetchMode (see https://psalm.dev/230)
    public function setFetchMode($fetchMode, $arg1 = null, $arg2 = null)

ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Schema/DrizzleSchemaManager.php:94:53 - Argument 1 of Doctrine\DBAL\Schema\DrizzleSchemaManager::_getPortableTableIndexesList has wrong name $tableIndexes, expecting $tableIndexRows as defined by Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableTableIndexesList (see https://psalm.dev/230)
    protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Schema/MySqlSchemaManager.php:78:53 - Argument 1 of Doctrine\DBAL\Schema\MySqlSchemaManager::_getPortableTableIndexesList has wrong name $tableIndexes, expecting $tableIndexRows as defined by Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableTableIndexesList (see https://psalm.dev/230)
    protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Schema/OracleSchemaManager.php:95:53 - Argument 1 of Doctrine\DBAL\Schema\OracleSchemaManager::_getPortableTableIndexesList has wrong name $tableIndexes, expecting $tableIndexRows as defined by Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableTableIndexesList (see https://psalm.dev/230)
    protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php:217:53 - Argument 1 of Doctrine\DBAL\Schema\PostgreSqlSchemaManager::_getPortableTableIndexesList has wrong name $tableIndexes, expecting $tableIndexRows as defined by Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableTableIndexesList (see https://psalm.dev/230)
    protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)


ERROR: ParamNameMismatch - lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php:175:53 - Argument 1 of Doctrine\DBAL\Schema\SqliteSchemaManager::_getPortableTableIndexesList has wrong name $tableIndexes, expecting $tableIndexRows as defined by Doctrine\DBAL\Schema\AbstractSchemaManager::_getPortableTableIndexesList (see https://psalm.dev/230)
    protected function _getPortableTableIndexesList($tableIndexes, $tableName = null)

[morozov]

but don't know which names are best

You can start a PR and we can figure out the names based on the changes.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.