Inconsistent naming of method arguments

[morozov]

Q	A
BC Break	no
Version	3.0.0-dev

In light of the Named Arguments RFC likely going to pass, it's important to have arguments named consistently across the API.

The following is an example but not a complete list of issues:

1. In AbstractPlatform methods, the database argument is mostly named $database but in some cases, it's $currentDatabase:
   

   dbal/src/Platforms/AbstractPlatform.php

   Line 2805 in 2efcbe2

   public function getListTableIndexesSQL($table, $currentDatabase = null)

2. Some classes override the parent classes method and unintentionally rename the argument:
   

   dbal/src/Platforms/AbstractPlatform.php

   Line 2749 in 2efcbe2

   public function getListTableColumnsSQL($table, $database = null)

   dbal/src/Platforms/SqlitePlatform.php

   Line 453 in 2efcbe2

   public function getListTableColumnsSQL($table, $currentDatabase = null)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.