Rename protected and private class members starting with an underscore

[morozov]

According to PSR-2, protected and private property and method names should not be prefixed with an underscore. Currently, we have some of them in the code base:

↪ git grep -P '(protected|private) (function |\$)_(?!_)' v2.8.0 | wc -l
284

In order to fix the coding standard violations, they should be renamed which would be backward incompatible. A major release could be used to make such a change.

[morozov]

Partially fixed in #3303 and #3306:

↪ git grep -P '(protected|private) (function |\$)_(?!_)' b45ed5e | wc -l
188

[Majkl578]

For the rest of protected underscored members, imho the best approach would be to make them private and expose protected constructor instead(#3007 (comment)). Should this be too annoying, there could be a __get() polyfill of some sort.
@Ocramius @morozov Thoughts?

[morozov]

For the rest of protected underscored members, imho the best approach would be to make them private and expose protected constructor instead

@Majkl578 you're still talking about breaking changes, right? Some of the currently protected variables like SQLSrvConnection::$conn are private by design, so we just need to declare them private. Also, I agree with #3007 (comment). We should see if we can make eligible classes final and then decide what to do with the rest of protected APIs. The style change will become a byproduct of this cleanup.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.