Add Criteria::fromFindCriteria

[soullivaneuh]

Subject

The goals is to be able to quick reproduce a criteria looking like parameters given to ORM find methods.

Concrete case

On a REST controller action, I would like to setup basic filter and apply them with the findBy method of the ORM.

I have a Server entity containing many User entities.

When the user calling the api method is not an admin, I have to filter the server list to get only related ones.

But the findBy does not allow us to do a search on a ManyToMany relationship.

I would like to keep same method on criteria to apply it on a query builder:

public function cgetAction(ParamFetcherInterface $paramFetcher)
{
    $view = $this->view();

    $filters = [
        'name' => $paramFetcher->get('name'),
    ];
    $filters = array_filter($filters, function ($value) {
        return null !== $value;
    });

    if ($this->get('admin.server')->isGranted('LIST')) {
        $servers = $this->getDoctrine()->getRepository('AppBundle:Server')->findBy($filters);
        $view->getSerializationContext()->setGroups(['list', 'list_admin']);
    } else {
        $servers = $this->getDoctrine()->getRepository('AppBundle:Server')->getByOwnerQB($this->getUser())
            ->addCriteria(Criteria::fromFindCriteria($filters))
            ->getQuery()->getResult();
        $view->getSerializationContext()->setGroups('list');
    }

    $view->setData($servers);

    return $view;
}

Having this method would simplify the logic.

[greg0ire]

"array" => "Criteria[]" ? Not sure what is used in this project…

[soullivaneuh]

Nope, this is the same as ObjectRepository::findBy method first parameter.

Ref: https://github.com/doctrine/common/blob/faf7d81273eeffb84d524006daf85d37a14ac42a/lib/Doctrine/Common/Persistence/ObjectRepository.php#L55

I'll add a comment.

[stof]

you should use fully qualified class names, as they are in a different package

[soullivaneuh]

@stof fixed.

[soullivaneuh]

Any news on this PR?

[mikeSimonson]

@soullivaneuh As far as I can see in the entityPersister, if you want to make the 2 compatible you have to take into account 3 more cases and their tests.

• The case were the value passed is an array and convert to IN
• The case were the value is an array and one of the value is null
• The case were the value is null

Thanks

[soullivaneuh]

@mikeSimonson Okay I'll see to update the tests first.

[lcobucci]

Please also address this (after a rebase to sync with master).

[lcobucci]

Please use short array syntax

[lcobucci]

Please use ::class syntax

[soullivaneuh]

@mikeSimonson I updated the code to manage the first case.

Stop me if I'm wrong, but I don't thing I have anything to do for the null cases.

This will be simply managed by this:

static::expr()->eq($key, $value);

Where $value will be null.