Add a note that #472 may leave proxies uninitialized #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Oct 29, 2025
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
LGTM with some wording changes
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Andreas Braun <[email protected]>
alcaeus
approved these changes
Oct 29, 2025
Member
|
Thanks @mpdude ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note to the UPGRADE file that opting in to #472 may cause a change in behaviour for proxy objects (#487).
Closes #487.