Leverage new array functions #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Aug 27, 2024
| * @template TKey of array-key | ||
| * @template TValue | ||
| */ | ||
| function array_find(array $array, callable $callback): mixed {} |
There was a problem hiding this comment.
Why is a stub needed for this function but not the others?
There was a problem hiding this comment.
Psalm does not know about the new functions yet. We need this stub, so Psalm can infer the correct return type for array_find(). The other two new functions I've used always return a boolean, so the native return types might be just good enough.
derrabus
force-pushed
the
improvement/array-find
branch
from
bbfc6fa
to
4267257
Compare
greg0ire
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 will add a couple of array functions that we can make use of:
https://wiki.php.net/rfc/array_find
I'm using Symfony's polyfill to make sure the functions are always available. If we don't want to add that dependency, we could also work with a PHP version check inside the methods I've changed.