Remove override of template type for contains(): causing psalm errors #369
Conversation
|
I remember having to add this because either Psalm or PHPStan complained… maybe it is no longer required. Should the same be done in Also, I notice this library still uses Psalm 4, we should upgrade 😓 |
|
I have not checked different versions of psalm, we're using psalm 5. Maybe this isn't backwards compatible with 4. I don't know... |
|
I don't think it is, otherwise the CI pipeline would fail, right? |
|
I created a separate PR to deal with Psalm: #370 Please address my other comment and we can merge this. |
|
Please also rebase, as I upgraded this lib to Psalm v5 |
Yes, |
|
I know, I was just asking politely that the issue be treated globally . No doubt it should be done. |
The override of this template type causes Psalm to throw an error whenever contains is called: https://psalm.dev/r/a2f9439bd2 Removing the extra type works as expected: https://psalm.dev/r/de5f58d52f Fixes doctrine#368
annervisser
force-pushed
the
remove-override-of-template-type-causing-psalm-errors
branch
from
aded07e
to
71a25d7
Compare
|
@greg0ire I was out of office for a couple of days, but I've now updated this PR |
|
Thanks @annervisser ! |
The override of this template type causes Psalm to throw an error whenever contains is called: https://psalm.dev/r/a2f9439bd2
Removing the extra type works as expected: https://psalm.dev/r/de5f58d52f
Fixes #368