Require constructor property promotion

[greg0ire]

I need to add more tests and to update the patches, but let's first examine together what happens on existing code and what to do about that.

[greg0ire]

This comment is lost. Should I report a bug about it? I've tried adding an @param phpdoc to the constructor, and it stays.

In your projects, when you use CPP, do you use @param, or do you annotate properties, like this:

public function __construct(
    /** @var list<string> */
    private array $someProperty,
   …
) {

[morozov]

I use the following:

/** @param list<EntitySlot> $slots */
public function __construct(
    private readonly array $slots,
) {
}

[simPod]

Same as @morozov

[kukulich]

@greg0ire I can add some options to the sniff if needed (in August).

[derrabus]

I think, this is fine. We have other sniffs plus static analysis in place that should already complain about the missing @param annotation.

[greg0ire]

There seems to be an agreement. What should I do then? Use @param in tests/fixed/example-class.php and fix the patches so that they apply cleanly? Or just keep as is so that this disappearance stays documented?

[derrabus]

Or just keep as is so that this disappearance stays documented?

Keeping it as it is, is fine I guess.