Skip to content

reproduce a bug when there is no comma after last element of associative array #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vv12131415 wants to merge 2 commits into from
Closed

reproduce a bug when there is no comma after last element of associative array #102

vv12131415 wants to merge 2 commits into from

Conversation

@vv12131415
Copy link
Contributor

@vv12131415 vv12131415 commented Dec 29, 2018

following https://twitter.com/IssecMura/status/1078827161434419200 and slevomat/coding-standard#490

it breaks only for associative arrays

I'm not sure if I need to change expected_report.txt

@carusogabriel
Copy link
Contributor

carusogabriel commented Dec 29, 2018 •
edited
Loading

The fixed file is missing.

@greg0ire
Copy link
Member

greg0ire commented Dec 29, 2018

The commit looks weird, why is it co-authored by @alcaeus ? Why does the "changes" tab tell about "full changes" and leads to a view where the Travis Ubuntu distribution changes?

@vv12131415
Copy link
Contributor Author

vv12131415 commented Dec 29, 2018

The commit looks weird, why is it co-authored by @alcaeus ? Why does the "changes" tab tell about "full changes" and leads to a view where the Travis Ubuntu distribution changes?

have no idea tbh

@greg0ire
Copy link
Member

greg0ire commented Dec 29, 2018

I would try fetching and rebasing, it looks like you amended a commit that wasn't yours or something…

@vv12131415
Copy link
Contributor Author

vv12131415 commented Jan 2, 2019

Done!

@lcobucci
Copy link
Member

lcobucci commented Jan 4, 2019

@vladyslavstartsev awesome, thanks! For some weird reason travis is not being triggered, I'll rebase your branch to see if that fixes it.

@lcobucci lcobucci mentioned this pull request Jan 4, 2019
Merged
vv12131415 and others added 2 commits January 4, 2019 12:14
@vv12131415 @lcobucci
Add failing test to reproduce bug with associative arrays
7c91339 
PHPCBF is adding two commas when fixing missing trailing commas on
associative arrays.
@lcobucci
Remove conflicting sniff
5776a11
@vv12131415 vv12131415 requested a review from a team as a code owner January 4, 2019 11:22
@lcobucci
Copy link
Member

lcobucci commented Jan 4, 2019

@vladyslavstartsev for some reason this PR is never triggering CI. I'll close it in favour of #103. Thanks a lot for your help!

@lcobucci lcobucci closed this Jan 4, 2019
@lcobucci lcobucci self-assigned this Jan 4, 2019
@Ocramius Ocramius added this to the 6.0.0 milestone Jan 4, 2019
@lcobucci lcobucci removed this from the 6.0.0 milestone Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcobucci lcobucci

Labels

bug duplicate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vv12131415 @carusogabriel @greg0ire @lcobucci @Ocramius