chore: show parameters in name of CI jobs#2142
Merged
greg0ire merged 1 commit intodoctrine:2.18.xfrom Nov 30, 2025
Merged
Conversation
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
51be889 to
a5c664a
Compare
greg0ire
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
I love the end result. Are there functions you could be using to make the code easier to maintain?
https://docs.github.com/en/actions/reference/workflows-and-actions/expressions
Maybe format and/or join could come in handy.
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
98ccd55 to
dbb067b
Compare
greg0ire
reviewed
Nov 29, 2025
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
dbb067b to
f1b8095
Compare
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
f1b8095 to
717d017
Compare
greg0ire
reviewed
Nov 29, 2025
Member
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
Looks good. Please squash your commits
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
717d017 to
14544f0
Compare
alexislefebvre
force-pushed
the
chore-show-parameters-in-name-of-CI-jobs
branch
from
14544f0 to
bd650d4
Compare
greg0ire
approved these changes
Nov 29, 2025
greg0ire
requested review from
SenseException,
derrabus,
dmaicher and
ostrolucky
derrabus
approved these changes
Nov 29, 2025
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Love it. Can you please to this for Doctrine DBAL and ORM as well? 🥺
This was referenced Nov 29, 2025
SenseException
approved these changes
Nov 30, 2025
Member
|
Thanks @alexislefebvre ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from:
The goal is to make the list more readable, before this PR it looked like this:
It display from 3 to 5 parameters, the first one can be the Symfony version or the PHP version, which is not easy to read.
With this PR, it looks like this: