Fix the build #2125
Merged
Fix the build #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5abeb29. The scanned file no longer exists since symfony/symfony#62129, which aims precisely at making the scan unnecessary (among other things).
They appear to be mandatory.
greg0ire
requested review from
GromNaN,
SenseException,
derrabus,
dmaicher,
nicolas-grekas and
ostrolucky
SenseException
approved these changes
Nov 1, 2025
| 'kernel.bundles' => $bundles, | ||
| 'kernel.cache_dir' => sys_get_temp_dir(), | ||
| 'kernel.build_dir' => sys_get_temp_dir(), | ||
| 'kernel.share_dir' => sys_get_temp_dir(), |
Member
There was a problem hiding this comment.
Weird, I don't find this one in the docs, but it's in a blog post.
Member
Author
There was a problem hiding this comment.
That's probably because it's necessary only when using development dependencies.
Member
Author
There was a problem hiding this comment.
@xabbuh this:
1) Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection\Compiler\IdGeneratorPassTest::testRepositoryServiceWiring
Symfony\Component\DependencyInjection\Exception\RuntimeException: You have requested a non-existent parameter "kernel.share_dir". Did you mean one of these: "kernel.cache_dir", "kernel.build_dir", "kernel.root_dir"?
/home/greg/dev/DoctrineBundle/vendor/symfony/dependency-injection/Compiler/DefinitionErrorExceptionPass.php:48
/home/greg/dev/DoctrineBundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
/home/greg/dev/DoctrineBundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820
/home/greg/dev/DoctrineBundle/tests/DependencyInjection/Compiler/IdGeneratorPassTest.php:102
Member
There was a problem hiding this comment.
Does the failure persist with the latest beta2 releases? If yes, we should probably check that this is not a bug in Symfony itself.
Member
Author
There was a problem hiding this comment.
The failure happens with Symfony 7.4.x-dev, even after running composer update:
$ composer outdated
Color legend:
- patch or minor release available - update recommended
- major release available - update possible
Direct dependencies required in composer.json:
doctrine/annotations 2.0.x-dev a64d7f0 2.0.x-dev a64d7f0 Docblock Annotations Parser
Package doctrine/annotations is abandoned, you should avoid using it. No replacement was suggested.
doctrine/cache 2.2.x-dev e0a9919 2.2.x-dev e0a9919 PHP Doctrine Cache library is a pop...
Package doctrine/cache is abandoned, you should avoid using it. No replacement was suggested.
doctrine/coding-standard 14.0.x-dev daecb56 15.0.x-dev 3d75de3 The Doctrine Coding Standard is a s...
doctrine/dbal 4.4.x-dev cd3a47a 5.0.x-dev 816ae13 Powerful PHP database abstraction l...
doctrine/deprecations 1.1.x-dev 4206996 2.0.x-dev a0433b3 A small layer on top of trigger_err...
doctrine/orm 3.6.x-dev 9e5442a 4.0.x-dev 0ed4630 Object-Relational-Mapper for PHP
doctrine/persistence 4.2.x-dev 82a5758 5.0.x-dev 4830826 The Doctrine Persistence project is...
phpstan/phpstan 2.1.1 2.1.x-dev PHPStan - PHP Static Analysis Tool
phpstan/phpstan-phpunit 2.0.3 2.0.x-dev 36cb9a6 PHPUnit extensions and rules for PH...
phpstan/phpstan-strict-rules 2.0.6 2.0.x-dev d6211c4 Extra strict and opinionated rules ...
phpunit/phpunit 12.5.x-dev 3affd93 dev-main 79fc96e The PHP Unit Testing framework.
symfony/cache 7.4.x-dev 5005632 8.0.x-dev 827c917 Provides extended PSR-6, PSR-16 (an...
symfony/config 7.4.x-dev 32c2687 8.0.x-dev 12d43bf Helps you find, load, combine, auto...
symfony/console 7.4.x-dev 0bb20e5 8.0.x-dev 828c469 Eases the creation of beautiful and...
symfony/dependency-injection 7.4.x-dev 3a5c2d3 8.0.x-dev b4f7f80 Allows you to standardize and centr...
symfony/doctrine-bridge 7.4.x-dev 0b89ae1 8.0.x-dev 51ea5a9 Provides integration for Doctrine w...
symfony/doctrine-messenger 7.4.x-dev 99cefdd 8.0.x-dev cbb5f37 Symfony Doctrine Messenger Bridge
symfony/expression-language 7.4.x-dev b53192c 8.0.x-dev 7823bc1 Provides an engine that can compile...
symfony/framework-bundle 7.4.x-dev 7127cd6 8.0.x-dev 49bdd10 Provides a tight integration betwee...
symfony/messenger 7.4.x-dev a19e7bc 8.0.x-dev 90d1777 Helps applications send and receive...
symfony/property-info 7.4.x-dev de3f7d4 8.0.x-dev b826ccd Extracts information about PHP clas...
symfony/security-bundle 7.4.x-dev b0db040 8.0.x-dev 08a1295 Provides a tight integration of the...
symfony/stopwatch 7.4.x-dev 8a24af0 8.0.x-dev 67df191 Provides a way to profile code
symfony/string 7.4.x-dev bc78521 8.0.x-dev f929ecc Provides an object-oriented API to ...
symfony/twig-bridge 7.4.x-dev 394bb14 8.0.x-dev 67db5a7 Provides integration for Twig with ...
symfony/validator 7.4.x-dev 865f7d1 8.0.x-dev a380084 Provides tools to validate values
symfony/var-exporter 7.4.x-dev 03a60f1 8.0.x-dev 7d3723b Allows exporting any serializable P...
symfony/web-profiler-bundle 7.4.x-dev 2de0734 8.0.x-dev d966de0 Provides a development tool that gi...
symfony/yaml 7.4.x-dev 0d7c67f 8.0.x-dev 2346745 Loads and dumps YAML files
twig/twig 3.x-dev 80fa13c 4.x-dev 7489911 Twig, the flexible, fast, and secur...
Transitive dependencies not required in composer.json:
dealerdirect/phpcodesniffer-composer-installer 1.1.2 dev-main f3d4d45 PHP_CodeSniffer Standards Composer ...
doctrine/collections 2.5.x-dev 9acfeea 3.0.x-dev 1b95024 PHP Doctrine Collections library th...
doctrine/inflector 2.2.x-dev 6d6c962 3.0.x-dev 09e50c5 PHP Doctrine Inflector is a small l...
phar-io/version 3.2.1 dev-master 5eeb03f Library for handling version inform...
psr/clock 1.0.0 dev-master fb246b4 Common interface for reading the cl...
staabm/side-effects-detector 1.0.5 dev-main c0aa29f A static analysis tool to detect si...
theseer/tokenizer 1.2.3 dev-master ccf2d17 A small library for converting toke...
Member
There was a problem hiding this comment.
I’m gonna check what’s going wrong.
Member
There was a problem hiding this comment.
I see, this happens because the DI extension from FrameworkBundle is initialised directly without a kernel which would take care of setting the parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues caused by changes in Symfony.