Merged
Conversation
greg0ire
requested review from
SenseException,
alcaeus,
beberlei,
derrabus,
malarzm,
morozov,
ostrolucky and
stof
Member
Author
|
To be tagged as 5.2.0 |
greg0ire
force-pushed
the
split-sa-workflow
branch
2 times, most recently
from
2940366 to
6571c9b
Compare
Member
Author
|
Note that I removed the workflow template so that this workflow no longer gets suggested when setting up new workflows through the github UI |
stof
reviewed
Oct 8, 2024
.github/workflows/phpstan.yml
Outdated
| strategy: | ||
| matrix: | ||
| php-version: | ||
| - "${{ inputs.php-version }}" |
Member
There was a problem hiding this comment.
why are we even using a matrix here, with a single value in the matrix ?
Member
Author
There was a problem hiding this comment.
IIRC it is to make the PHP version appear in the label of the job.
Member
There was a problem hiding this comment.
you can use name: "PHPStan (php: ${{ inputs.php-version }})" to make that in a simpler way AFAIK (and with an explicit intent)
| - name: "Run a static analysis with phpstan/phpstan" | ||
| run: "vendor/bin/phpstan analyse -v" | ||
| name: "PHPStan (deprecated in favor of phpstan.yml)" | ||
| uses: "./.github/workflows/phpstan.yml" |
Member
There was a problem hiding this comment.
shouldn't this forward the inputs instead of using the defaults of the phpstan.yml workflow ?
greg0ire
force-pushed
the
split-sa-workflow
branch
from
6571c9b to
ae081ea
Compare
Merged
Merged
This should allow downstream projects to better prepare for the Psalm removal: they can use the new phpstan workflow whenever they want to drop Psalm, and when all of them do, then we can drop the static analysis workflow form this repository.
greg0ire
force-pushed
the
split-sa-workflow
branch
from
ae081ea to
c5b75c1
Compare
derrabus
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow downstream projects to better prepare for the Psalm removal: they can use the new phpstan workflow whenever they want to drop Psalm, and when all of them do, then we can drop the static analysis workflow form this repository.
Proof that it does not break the old workflow: greg0ire/collections#2
Proof that the new workflow works: greg0ire/collections#3