fix: Fix duplicate sidebar when include audio file #1521
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/8UaF2UC3VEdx2pCEW4yZMtfeWCgt |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11e5020:
|
sy-records
requested review from
Koooooo-7,
anikethsaha,
jhildenbiddle and
trusktr
| if (_self.uniqueTOC.indexOf(url) === -1) { | ||
| _self.uniqueTOC.push(url); | ||
| _self.toc.push(nextToc); | ||
| } |
There was a problem hiding this comment.
It is not clear what this changes or how the original problem happens. Can you explain?
There was a problem hiding this comment.
There was a problem hiding this comment.
You only pointed to some code. Can you explain?
media files should not have anything to do with the sidebar, so it seems this is not the correct fix, and that we should fix a problem with embedding media (or other stuff too maybe).
There was a problem hiding this comment.
What I mean is, that fact that this code seems entirely unrelated to media files, yet fixes the problem, seems more like a workaround than an actual fix.
firstly, why does adding media files cause duplication?
|
I'm having the same issue. When I include more than 1 video file in the page, the sidebar menu will loop for several times if refresh the page or open the page via link. If will be correct if coming from another page. It is very annoying since I need to share the docs link to others and the menu looped like broken. |
| if (_self.uniqueTOC.indexOf(url) === -1) { | ||
| _self.uniqueTOC.push(url); | ||
| _self.toc.push(nextToc); | ||
| } |
There was a problem hiding this comment.
What I mean is, that fact that this code seems entirely unrelated to media files, yet fixes the problem, seems more like a workaround than an actual fix.
firstly, why does adding media files cause duplication?
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.