Skip to content

fix: sidebar active class and expand don't work as expect when use "space" in markdown filename #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2020
Merged

fix: sidebar active class and expand don't work as expect when use "space" in markdown filename #1454

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f99675
fix: decode href in sidebar (#1032)
enzy Dec 17, 2020
12f9d03
Merge branch 'develop' into fix/1032
sy-records Dec 18, 2020
92c6810
Create sidebar.test.js
sy-records Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/event/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function getAndActive(router, el, isParent, autoTitle) {
links
.sort((a, b) => b.href.length - a.href.length)
.forEach(a => {
const href = a.getAttribute('href');
const href = decodeURI(a.getAttribute('href'));
const node = isParent ? a.parentNode : a;

a.title = a.title || a.innerText;
Expand Down