Fixes parsing of [default: x] in some cases on Win. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the option definition spans over multiple lines, then parsing of the [default: x] was not working on Windows - tested on MS Visual Studio 2015. This is due to the differences in regex's multiline property implementation. On some platforms - Linux libstd++ the multiline property is off, on some platforms - msvc2015 the multiline property is on. It cannot be changed programmatically AFAIK. I was not able to come up with a regex expression which would work on Linux and on Windows as well. So I tried to be smart and replace '\n' by '\f' in the string beforehand. The regex was easy and worked on Linux and Windows just fine - up until I tried a longer option definition. Then the msvc2015 regex failed with 'stack' exception. Hence this change. It splits the option definition section by a simple regex which does not use the problematic '$'. modified: docopt.cpp modified: docopt_util.h
Usage:
prog [--foo <foo_>] [--baz <baz_>]
Options:
--foo <foo_>
Foo [default: 42]
--baz <baz_>
Baz [default: 1]
modified: testcases.docopt
|
Docopt.cpp is a port of the original docopt, and the test-case file comes directly from there. I'm hesitant to fork that file without good reason. Would you be willing to offer your test-case to that repo first? (https://github.com/docopt/docopt) I've already verified it passes the original docopt, so I think it would be a valuable addition! Then, I think we can pull your patch+test direclty in. Sound ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
there is a problem if the option definition spans over multiple lines, then parsing of the [default: x] was not working on Windows - tested on MS Visual Studio 2015.
This is due to the differences in regex's multiline property implementations.
On some platforms - Linux libstd++ the multiline property is off,
on some platforms - msvc2015 the multiline property is on.
It cannot be changed programmatically AFAIK.
I was not able to come up with a regex expression which
would work on Linux and on Windows as well. So I tried to be
smart and replace '\n' by '\f' in the string beforehand.
The regex was easy and worked on Linux and Windows just fine -
up until I tried a longer option definition. Then the msvc2015
regex failed with 'stack' exception. Hence this change.
It splits the option definition section by a simple regex
which does not use the problematic '$'.
Tell me what you think. All tests are passing.
Regards,
Roman