Fix/export operator symbol #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those patches have been applied in the conan-center-index related PR, which builds a lot of Windows configurations. If the CI passes there, it should be good! |
|
Seems like Travis is unhappy about some packages to install |
tdegeus
reviewed
Dec 10, 2019
|
@theodelrieu Any chance that you know what is going on in #124 ? |
jaredgrubb
reviewed
Dec 30, 2019
theodelrieu
force-pushed
the
fix/export_operator_symbol
branch
from
0d4bac6
to
6146dd5
Compare
|
This looks good, though I'm not a Cmake pro so would love to have someone else +1 this just so we get someone qualified to look! |
|
I can confirm that it fixes #125 . (I haven't dived in to the details of the rest of the change.) |
|
This PR had a merge issue, and I couldn't figure out how to resolve it here, so I just cloned the branch and fixed in. Merged in #151. |
|
Thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jared,
I know some PRs are already opened to fix both issues fixed by this one (i.e. DLL interface for operator<< and building only one target at a time), but they are stalling since a few months right now, so I hope this will make it go forward 😄