Fix scheduled refresh #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated description
Below is a concise technical summary of the changes proposed in this PR:
graph LR initialize_with_token_refresh_("initialize_with_token_refresh"):::modified TokenManager_("TokenManager"):::modified TokenManager_set_config_manager_("TokenManager.set_config_manager"):::added TokenManager_get_valid_token_("TokenManager.get_valid_token"):::modified TokenManager_verify_token_("TokenManager.verify_token"):::modified TokenManager_start_refresh_task_("TokenManager.start_refresh_task"):::modified TokenManager_refresh_access_token_("TokenManager.refresh_access_token"):::modified TokenManager_config_manager_("TokenManager.config_manager"):::modified CONFIG_MANAGER_("CONFIG_MANAGER"):::added TokenManager_clone_("TokenManager.clone"):::modified initialize_with_token_refresh_ -- "Injects ConfigManager into TokenManager for token persistence" --> TokenManager_ initialize_with_token_refresh_ -- "Adds method to inject ConfigManager for automatic token saving" --> TokenManager_set_config_manager_ initialize_with_token_refresh_ -- "Triggers token refresh that now persists token via ConfigManager" --> TokenManager_get_valid_token_ initialize_with_token_refresh_ -- "Verifies token after refresh with added success logging" --> TokenManager_verify_token_ initialize_with_token_refresh_ -- "Adds info log on successful background token refresh" --> TokenManager_start_refresh_task_ TokenManager_refresh_access_token_ -- "Persists refreshed token to config file via ConfigManager" --> TokenManager_config_manager_ TokenManager_refresh_access_token_ -- "Integrates external ConfigManager service for token persistence" --> CONFIG_MANAGER_ TokenManager_clone_ -- "Clones ConfigManager Arc to preserve shared ownership" --> TokenManager_config_manager_ classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13pxRefactor the
TokenManagerto centralize token persistence logic, ensuring refreshed access tokens are automatically written to the configuration file, thereby fixing scheduled refresh issues. Standardize project branding by renaming environment variables, binary names, and documentation fromAPOLLO_toDC_.startupmodule directly into theTokenManager'srefresh_access_tokenmethod. This change injects theConfigManagerinto theTokenManagerviaset_config_manager, making the token persistence process more robust and self-contained, and ensuring that refreshed tokens are consistently saved.Modified files (2)
Latest Contributors(1)
APOLLO_prefixed environment variables, binary names, and documentation references toDC_. This includes changes in runtime environment variable handling, main application entry points, and extensive updates to theREADME.mdfile, as well as corresponding updates to introspection test snapshots to reflect the new naming conventions.Modified files (5)
Latest Contributors(2)