perf: 25% speed gain on json serialization through orjson... #455
+115
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ DCO Check Passed Thanks @VerdantForge, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Related Documentation Checked 7 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Artolomeus
force-pushed
the
faster-json-serialization-through-orjson
branch
from
7594d33 to
9890b37
Compare
In the DoclingDocument classn 25% speed gain on json serialization through orjson. BREAKING CHANGE: orjson replaces indent option by option=orjson.OPT_INDENT_2 and only supports indent 2. BREAKING CHANGE: orjson drops ensure_ascii option and cannot escape UTF-8 to ASCII Signed-off-by: Nicholas Greensmith <[email protected]>
Artolomeus
force-pushed
the
faster-json-serialization-through-orjson
branch
from
9890b37 to
5b83903
Compare
VerdantForge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orjson allows for blazing fast serialization/deserialization of json in python. applying this to
save_as_jsonallows us to save an incredible 50ms on some documents (25% serialization time reduction).fixes: #451
BREAKING_CHANGES: