-
Notifications
You must be signed in to change notification settings - Fork 114
fix: drop malformed bounding boxes #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ DCO Check Failed Hi @b-hahn, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for Benjamin Hahn <[email protected]>
I, Benjamin Hahn <[email protected]>, hereby add my Signed-off-by to this commit: 5e71eec8d01cd6d05caa470561962d2f8a9533a7"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
ff062c3 to
1c3bd97
Compare
Signed-off-by: Benjamin Hahn <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I think that @b-hahn from yesterday would require another approval of the CI runs on your end. :) |
|
@b-hahn you identified the right function, i.e. |
|
@dolfim-ibm we agreed on the proposed solution here. It’s legit for some elements to have missing prov |
This change handles the case where bounding boxes predicted by VLMs have a width or a height <=0. Previously, this would cause the pipeline to crash while saving the PIL image. Now, malformed bounding boxes are simply ignored, resulting in an empty provenance field while keeping the extracted text.
Fixes docling-project/docling#2763