Skip to content

Conversation

@ceberam
Copy link
Member

@ceberam ceberam commented Nov 17, 2025

This PR introduces a new type of provenance object for media files.

It also resolves docling-project/docling#2525

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

DCO Check Passed

Thanks @ceberam, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Nov 17, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@ceberam ceberam force-pushed the dev/webvtt branch 2 times, most recently from 295c5ac to 0c201e2 Compare November 17, 2025 08:43
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 93.03621% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/types/doc/webvtt.py 92.40% 23 Missing ⚠️
docling_core/transforms/serializer/azure.py 83.33% 1 Missing ⚠️
...core/transforms/visualizer/key_value_visualizer.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ceberam ceberam self-assigned this Nov 27, 2025
@ceberam ceberam force-pushed the dev/webvtt branch 2 times, most recently from 9e26200 to a0f4404 Compare December 4, 2025 10:02
@ceberam ceberam added the enhancement New feature or request label Dec 4, 2025
@ceberam ceberam force-pushed the dev/webvtt branch 3 times, most recently from c2efd15 to 4ecde67 Compare December 5, 2025 14:20
Since WebVTTTimestamp is used in DoclingDocument, the class should be public.
Strengthen validation of cue language start tag annotation.

Signed-off-by: Cesar Berrospi Ramis <[email protected]>

Signed-off-by: Cesar Berrospi Ramis <[email protected]>
@ceberam ceberam marked this pull request as ready for review December 15, 2025 08:39
@dosubot
Copy link

dosubot bot commented Dec 15, 2025

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported features in WebVTT parser

2 participants