Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy_snapshot.yml #4864

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Apr 19, 2022

Description
develop should deploy Docker images too for nightly deploy

For review, you'll want to look at the second last github action build
https://github.com/dockstore/dockstore/runs/6086294854?check_suite_focus=true
to see if things seem to be headed to the right locations on quay.io and S3

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4254

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • Check the Snyk dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future

@denis-yuen denis-yuen self-assigned this Apr 19, 2022
@denis-yuen denis-yuen marked this pull request as ready for review April 19, 2022 22:48
@denis-yuen
Copy link
Member Author

Will followup for ticket to share code in actions
actions/runner#646

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #4864 (93c64ec) into develop (66ce339) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4864   +/-   ##
==========================================
  Coverage      69.16%   69.16%           
  Complexity      3991     3991           
==========================================
  Files            286      286           
  Lines          16413    16413           
  Branches        1810     1810           
==========================================
  Hits           11352    11352           
  Misses          4209     4209           
  Partials         852      852           
Flag Coverage Δ
integrationtests 58.12% <ø> (ø)
languageparsingtests 8.39% <ø> (ø)
toolintegrationtests 31.12% <ø> (ø)
workflowintegrationtests 41.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ce339...93c64ec. Read the comment docs.

@denis-yuen
Copy link
Member Author

@denis-yuen denis-yuen merged commit 2536809 into develop Apr 20, 2022
@denis-yuen denis-yuen deleted the feature/deploy_docker_develop branch April 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants