Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Coconut - an Attribute-Based Credential Scheme with Threshold Issuance based on the modified Pointcheval-Sanders signature #10

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Integrate Coconut - an Attribute-Based Credential Scheme with Threshold Issuance based on the modified Pointcheval-Sanders signature #10

merged 9 commits into from
Mar 23, 2023

Conversation

olegnn
Copy link
Contributor

@olegnn olegnn commented Mar 22, 2023 •
edited
Loading

  • Move the Coconut implementation (based on the modified Pointcheval-Sanders signature) into the docknetwork/crypto
  • Integrate signature's NIZK (SignaturePoK) into the composite proof system
  • Restore old benchmarks and add new benchmarks for the signature and proof of knowledge
  • Implement tests for this integration based on the tests for BBS+ signature, use PedersenCommitment instead of MessagesPoK as messages NIZK
  • Misc tweaks

@olegnn olegnn changed the title Integrate the modified ps-signature implementation used in Coconut Integrate the modified Pointcheval-Sanders signature implementation used in Coconut Mar 22, 2023
lovesh
lovesh requested changes Mar 23, 2023
View reviewed changes
bbs_plus/src/proof.rs Show resolved Hide resolved
ps-signature/src/macros.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
ps-signature/Cargo.toml Outdated Show resolved Hide resolved
@olegnn olegnn changed the title Integrate the modified Pointcheval-Sanders signature implementation used in Coconut Integrate Coconut based on the modified Pointcheval-Sanders signature Mar 23, 2023
@olegnn olegnn changed the title Integrate Coconut based on the modified Pointcheval-Sanders signature Integrate Coconut - an Attribute-Based Credential Scheme with Threshold Issuance based on the modified Pointcheval-Sanders signature Mar 23, 2023
@olegnn olegnn merged commit 0d3bc3a into main Mar 23, 2023
lovesh pushed a commit that referenced this pull request Mar 24, 2023
@olegnn @lovesh
Integrate Coconut - an Attribute-Based Credential Scheme with Thres…
183eeb7 
…hold Issuance based on the modified Pointcheval-Sanders signature (#10)

* Integrate `ps-signature` implementation

* Enable CI on PR

* Fix feature gates

* Update comments

* Sync

* `ps-signature` -> `coconut`

* Bump up versions

* `CommitmentsPoK` -> `MessagesPoK`

* Stylistic

Signed-off-by: lovesh <[email protected]>
@lovesh lovesh deleted the ps-signature branch May 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesh lovesh lovesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegnn @lovesh