Throw error when trying to encode undefined value (#15)

* Throw error when trying to encode undefined value Signed-off-by: Samuel Hellawell <[email protected]> * test case Signed-off-by: Samuel Hellawell <[email protected]> --------- Signed-off-by: Samuel Hellawell <[email protected]>
docknetwork · Mar 20, 2023 · f6e26c3 · f6e26c3
1 parent 235b7f0
commit f6e26c3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@docknetwork/crypto-wasm-ts",
-  "version": "0.31.1",
+  "version": "0.31.2",
   "description": "Typescript abstractions over Dock's Rust crypto library's WASM wrapper",
   "homepage": "https://github.com/docknetwork/crypto-wasm-ts",
   "main": "lib/index.js",

diff --git a/src/bbs-plus/encoder.ts b/src/bbs-plus/encoder.ts
@@ -41,6 +41,9 @@ export class Encoder {
   encodeMessage(name: string, value: unknown, strict = false): Uint8Array {
     const encoder = this.encoders?.get(name) || this.defaultEncoder;
     if (encoder !== undefined) {
+      if (typeof value === undefined) {
+        throw new Error(`Cannot encode message with name ${name} as it is undefined`);
+      }
       return encoder(value);
     } else {
       if (!strict && value instanceof Uint8Array) {

diff --git a/tests/composite-proofs/msg-js-obj/util.spec.ts b/tests/composite-proofs/msg-js-obj/util.spec.ts
@@ -73,6 +73,9 @@ describe('Utils', () => {
     encoders1.set('foo', Encoder.positiveIntegerEncoder());
     const encoder1 = new Encoder(encoders1);
 
+    // Throws for undefined message
+    expect(() => encoder1.encodeMessage('bar', undefined)).toThrow();
+
     // Throws for unknown message name when no default encoder
     expect(() => encoder1.encodeMessage('bar', 6)).toThrow();
     expect(() => encoder1.encodeMessageObject({ bar: 6, foo: 10 })).toThrow();