Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cloud prefix optional to download buildx if driver is cloud #390

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 12, 2024

This allows to specify version without cloud: prefix when driver is set to cloud. See new test cases for more information.

Note that the current behavior for other drivers is to use current buildx version available on GitHub Runners if version is not set while with cloud driver it would always download the latest stable because we don't expect buildx cloud releases available on public runners.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Copy link
Member

@mikesir87 mikesir87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick turnaround here!

@tonistiigi tonistiigi merged commit 6524bf6 into docker:master Dec 12, 2024
44 checks passed
@crazy-max crazy-max deleted the buildx-cloud-latest branch December 12, 2024 18:33
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Dec 23, 2024
…p ci]

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.7.1 to 3.8.0.
Release notes

*Sourced from [docker/setup-buildx-action's releases](https://github.com/docker/setup-buildx-action/releases).*

> v3.8.0
> ------
> 
> * Make cloud prefix optional to download buildx if driver is cloud by [`@​crazy-max`](https://github.com/crazy-max) in [docker/setup-buildx-action#390](https://github.com/docker/setup-buildx-action/pull/390)
> * Bump `@​actions/core` from 1.10.1 to 1.11.1 in [docker/setup-buildx-action#370](https://github.com/docker/setup-buildx-action/pull/370)
> * Bump `@​docker/actions-toolkit` from 0.39.0 to 0.48.0 in [docker/setup-buildx-action#389](https://github.com/docker/setup-buildx-action/pull/389)
> * Bump cross-spawn from 7.0.3 to 7.0.6 in [docker/setup-buildx-action#382](https://github.com/docker/setup-buildx-action/pull/382)
> 
> **Full Changelog**: <docker/setup-buildx-action@v3.7.1...v3.8.0>


Commits

* [`6524bf6`](docker/setup-buildx-action@6524bf6) Merge pull request [#390](https://github.com/docker/setup-buildx-action/issues/390) from crazy-max/buildx-cloud-latest
* [`8d5e074`](docker/setup-buildx-action@8d5e074) chore: update generated content
* [`7199e57`](docker/setup-buildx-action@7199e57) make cloud prefix optional to download buildx if driver is cloud
* [`db63cee`](docker/setup-buildx-action@db63cee) Merge pull request [#381](https://github.com/docker/setup-buildx-action/issues/381) from docker/dependabot/github\_actions/codecov/codecov...
* [`043ebe1`](docker/setup-buildx-action@043ebe1) Merge pull request [#389](https://github.com/docker/setup-buildx-action/issues/389) from docker/dependabot/npm\_and\_yarn/docker/actions-to...
* [`686da90`](docker/setup-buildx-action@686da90) chore: update generated content
* [`a3d7487`](docker/setup-buildx-action@a3d7487) Merge pull request [#382](https://github.com/docker/setup-buildx-action/issues/382) from docker/dependabot/npm\_and\_yarn/cross-spawn-7.0.6
* [`4dcdbce`](docker/setup-buildx-action@4dcdbce) build(deps): bump `@​docker/actions-toolkit` from 0.39.0 to 0.48.0
* [`1a8ac74`](docker/setup-buildx-action@1a8ac74) ci: fix deprecated input for codecov-action
* [`e827ebe`](docker/setup-buildx-action@e827ebe) build(deps): bump cross-spawn from 7.0.3 to 7.0.6
* Additional commits viewable in [compare view](docker/setup-buildx-action@c47758b...6524bf6)

  

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=docker/setup-buildx-action&package-manager=github\_actions&previous-version=3.7.1&new-version=3.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants