Skip to content

Fix Linux CPU build: add spirv-headers dependency #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericcurtin merged 1 commit into from
Apr 20, 2026
Merged

Fix Linux CPU build: add spirv-headers dependency #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llamacpp/native/install-vulkan.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
main() {
set -eux -o pipefail

apt-get install -y glslc libvulkan-dev
apt-get install -y glslc libvulkan-dev spirv-headers

@gemini-code-assist gemini-code-assist Bot Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Running apt-get install without a preceding apt-get update in the same execution block can lead to build failures in Docker environments if the package index is stale. Additionally, cleaning up /var/lib/apt/lists/* is best practice to maintain consistency with other scripts in the repository (such as scripts/apt-install.sh) and to minimize the footprint of the build layer.

Suggested change
apt-get install -y glslc libvulkan-dev spirv-headers
apt-get update
apt-get install -y glslc libvulkan-dev spirv-headers
rm -rf /var/lib/apt/lists/*
References
  1. The repository style guide prioritizes correctness and maintainability. Ensuring a reliable build process by updating package indexes and cleaning up is essential for these goals. (link)

}

main "$@"
Expand Down