Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

OpenStack driver: define multiple networks and select floating point network #4756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Turmio
Copy link

@Turmio Turmio commented Sep 25, 2019

Description

This PR adds support for OpenStack environment where access to multiple networks is required. Our use case is to use Docker Machine to auto scale GitLab runners in environment where runners are controlled from internal network and runner VM has access to other network(s).

Related issue(s)

@keviiin38
Copy link

keviiin38 commented Sep 4, 2020

This PR adds support for OpenStack environment where access to multiple networks is required. Our use case is to use Docker Machine to auto scale GitLab runners in environment where runners are controlled from internal network and runner VM has access to other network(s).

Very useful feature ! I've the exact same use-case, how did you manage this for the moment @Turmio ?

@Turmio
Copy link
Author

Turmio commented Sep 5, 2020

Hi @keviiin38!

Actually I have build binaries in GitLab: https://gitlab.com/Turmio/machine
Seems like artifacts are already removed. I could rebase this PR to latest master and rebuild binaries for you.

We use this version of docker machine to auto scale GitLab runners. Since golang builds single file binary, we just put binary to /usr/bin and configured gitlab runner to use openstack with these new switches.

@Turmio
Copy link
Author

Turmio commented Sep 5, 2020

Oh, Circle CI config isn't valid anymore. GitLab config seems to be fine: https://gitlab.com/Turmio/machine/-/pipelines/186178953
If GitLab is not familiar to you, artifacts can be download from repository main page, from pipelines page or from individual job page (eg. linux amd64 job).

@keviiin38
Copy link

Hello @Turmio !

Thanks for the explanation, got your PR working by just applying your patch locally (without Circle CI modification) and rebuilding the binary using Golang ! Working perfectly !

If you are okay, can I submit a MR on the "official" forked version of Docker Machine from Gitlab (here), with your changes on this PR ?

@Turmio
Copy link
Author

Turmio commented Sep 8, 2020

@keviiin38 thanks! I did not know about "official" forked version. I made MR myself yesterday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants