Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for public ECR #37

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Add support for public ECR #37

merged 1 commit into from
Dec 11, 2020

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 11, 2020

Fixes #36

cc. @clarkbw @vincentsarago

Signed-off-by: CrazyMax [email protected]

@crazy-max
Copy link
Member Author

crazy-max commented Dec 11, 2020

GitHub Runners does not currently support ecr-public command. (AWS CLI 2.1.4 on ubuntu-20.04 and AWS CLI 1.18.185 on ubuntu-latest). Comment added on upstream repo actions/runner-images#2219 (comment):

💡 AWS Public ECR detected with us-east-1 region
⬇️ Retrieving docker login command through AWS CLI 2.1.4 (/usr/local/bin/aws)...
Error: usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
To see help text, you can run:

  aws help
  aws <command> help
  aws <command> <subcommand> help

aws: error: argument command: Invalid choice, valid choices are:

accessanalyzer                           | acm                                     
acm-pca                                  | alexaforbusiness                        
amplify                                  | apigateway                              
apigatewaymanagementapi                  | apigatewayv2                            
appconfig                                | appflow                                 
application-autoscaling                  | application-insights                    
appmesh                                  | appstream                               
appsync                                  | athena                                  
autoscaling                              | autoscaling-plans                       
backup                                   | batch                                   
braket                                   | budgets                                 
ce                                       | chime                                   
cloud9                                   | clouddirectory                          
cloudformation                           | cloudfront                              
cloudhsm                                 | cloudhsmv2                              
cloudsearch                              | cloudsearchdomain                       
cloudtrail                               | cloudwatch                              
codeartifact                             | codebuild                               
codecommit                               | codeguru-reviewer                       
codeguruprofiler                         | codepipeline                            
codestar                                 | codestar-connections                    
codestar-notifications                   | cognito-identity                        
cognito-idp                              | cognito-sync                            
comprehend                               | comprehendmedical                       
compute-optimizer                        | connect                                 
connectparticipant                       | cur                                     
databrew                                 | dataexchange                            
datapipeline                             | datasync                                
dax                                      | detective                               
devicefarm                               | directconnect                           
discovery                                | dlm                                     
dms                                      | docdb                                   
ds                                       | dynamodb                                
dynamodbstreams                          | ebs                                     
ec2                                      | ec2-instance-connect                    
ecr                                      | ecs                                     
efs                                      | eks                                     
elastic-inference                        | elasticache                             
elasticbeanstalk                         | elastictranscoder                       
elb                                      | elbv2                                   
emr                                      | es                                      
events                                   | firehose                                
fms                                      | forecast                                
forecastquery                            | frauddetector                           
fsx                                      | gamelift                                
glacier                                  | globalaccelerator                       
glue                                     | greengrass                              
groundstation                            | guardduty                               
health                                   | honeycode                               
iam                                      | identitystore                           
imagebuilder                             | importexport                            
inspector                                | iot                                     
iot-data                                 | iot-jobs-data                           
iot1click-devices                        | iot1click-projects                      
iotanalytics                             | iotevents                               
iotevents-data                           | iotsecuretunneling                      
iotsitewise                              | iotthingsgraph                          
ivs                                      | kafka                                   
kendra                                   | kinesis                                 
kinesis-video-archived-media             | kinesis-video-media                     
kinesis-video-signaling                  | kinesisanalytics                        
kinesisanalyticsv2                       | kinesisvideo                            
kms                                      | lakeformation                           
lambda                                   | lex-models                              
lex-runtime                              | license-manager                         
lightsail                                | logs                                    
machinelearning                          | macie                                   
macie2                                   | managedblockchain                       
marketplace-catalog                      | marketplace-entitlement                 
marketplacecommerceanalytics             | mediaconnect                            
mediaconvert                             | medialive                               
mediapackage                             | mediapackage-vod                        
mediastore                               | mediastore-data                         
mediatailor                              | meteringmarketplace                     
mgh                                      | migrationhub-config                     
mobile                                   | mq                                      
mturk                                    | mwaa                                    
neptune                                  | network-firewall                        
networkmanager                           | opsworks                                
opsworkscm                               | organizations                           
outposts                                 | personalize                             
personalize-events                       | personalize-runtime                     
pi                                       | pinpoint                                
pinpoint-email                           | pinpoint-sms-voice                      
polly                                    | pricing                                 
qldb                                     | qldb-session                            
quicksight                               | ram                                     
rds                                      | rds-data                                
redshift                                 | redshift-data                           
rekognition                              | resource-groups                         
resourcegroupstaggingapi                 | robomaker                               
route53                                  | route53domains                          
route53resolver                          | s3control                               
s3outposts                               | sagemaker                               
sagemaker-a2i-runtime                    | sagemaker-runtime                       
savingsplans                             | schemas                                 
sdb                                      | secretsmanager                          
securityhub                              | serverlessrepo                          
service-quotas                           | servicecatalog                          
servicecatalog-appregistry               | servicediscovery                        
ses                                      | sesv2                                   
shield                                   | signer                                  
sms                                      | snowball                                
sns                                      | sqs                                     
ssm                                      | sso                                     
sso-admin                                | sso-oidc                                
stepfunctions                            | storagegateway                          
sts                                      | support                                 
swf                                      | synthetics                              
textract                                 | timestream-query                        
timestream-write                         | transcribe                              
transfer                                 | translate                               
waf                                      | waf-regional                            
wafv2                                    | workdocs                                
worklink                                 | workmail                                
workmailmessageflow                      | workspaces                              
xray                                     | s3api                                   
s3                                       | ddb                                     
configure                                | deploy                                  
configservice                            | opsworks-cm                             
history                                  | cli-dev                                 
help

Copy link
Contributor

@metcalfc metcalfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@metcalfc metcalfc merged commit 3b14bab into docker:master Dec 11, 2020
@crazy-max crazy-max deleted the public-ecr branch December 17, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supporting AWS public registry: public.ecr.aws
2 participants