Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the verbose logout error displayed when the user is already disco… #166

Merged

Conversation

moshebe
Copy link
Contributor

@moshebe moshebe commented Jan 31, 2021

- What I did
Fixed the "scary" message that was displayed when hub-tool logout when the user is already logged-out
closes #154

- How I did it
When the erase of the hub-tool key from the store is failed I added a little check to make sure the key does not exists.

- How to verify it
Run hub-tool logout before hub-tool login.
You can also log out more than once as well.

- Description for the changelog

Fixed logout error when the user is already logged-out

- A picture of a cute animal (not mandatory)

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks

Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chris-crone chris-crone merged commit 61aff7a into docker:main Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hub-tool logout produces scary error message when not logged in
3 participants