Allow the config API consumer to modify the serv/client default configs #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configs Signed-off-by: Nassim 'Nass' Eddequiouaq <[email protected]>
|
Should we have a minimal unit-test that sets some defaults in https://github.com/n4ss/go-connections/blob/5bd7d320e8c44eaa221c55748c646a0b74a04c7e/tlsconfig/config_test.go ? |
|
@thaJeztah of course, will fix! |
Signed-off-by: Nassim 'Nass' Eddequiouaq <[email protected]>
n4ss
force-pushed
the
adjust-default-config
branch
from
6b75191 to
088c242
Compare
|
MY tests are successful, :D
|
|
fwiw it's green on my linux machine(s), merging 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to adjust adjust the TLS minimum version from the server default's TLS config in the engine without breaking the interface in
go-connections.It's already possible to modify the more complete
Server()configuration through theoptionsparameter but not theServerDefaultone so we added a variadic modifier parameter.ps: thanks @vdemeester.
cc @thaJeztah @vieux
Signed-off-by: Nassim 'Nass' Eddequiouaq [email protected]