sockets: make NewUnixSocket, WithChown, WithChmod unix-only #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
thaJeztah
force-pushed
the
sockets_move_unix_options
branch
from
d2fda56 to
86ca1a3
Compare
The WithChown and WithChmod options are not supported on Windows. We could provide stubs in future, but let's start with not including them. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
sockets_move_unix_options
branch
from
86ca1a3 to
9ffab7e
Compare
vvoland
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WithChown and WithChmod options are not supported on Windows. We could provide stubs in future, but let's start with not including them.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)