NFS php readdir + rmdir failure

[colradec]

Description

This Issue is about the combination of a readdir loop with a removal of the included subdirs (also described here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=57696). It is hard to locate the real issue, as there are some cases, where it syncs correctly (https://github.com/moodle/moodle/blob/43c7557e847f8520eb55a7e78ba94180d27aaa42/lib/moodlelib.php#L10041). This function is called multiple times in the installation process but does not fail all the time and for the other cases it is not reproducible anymore.

The reason why I opened this bug report here: Until the version 4.21.1, everything works fine, all of the time, tested with PHP Versions 7.4 up to 8.2. However, from 4.22.0 until now (4.28.0) this behavior has not been fixed. I checked all changelogs regarding 4.22.0 but found nothing regarding the NFS or Mount implementation that would affect this. Even the MacOS Version does not affect this.

Reproduce

1. Use a PHP fpm/cgi docker image and using the gRPC FUSE (VirtIO cannot be used because of the SSH_AUTH_SOCKET mount)
2. Use a NFS mount with the following parameters o: "addr=host.docker.internal,rw,nolock,nfsvers=3,wsize=32767,rsize=32767"
3. Make a dir with nested subdirs.
4. make a readdir loop with rmdir.

Expected behavior

rmdir should sync to the NFS server that the dir has been deleted (4.21.1 behavior).

docker version

Client:
 Cloud integration: v1.0.35+desktop.11
 Version:           25.0.3
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        4debf41
 Built:             Tue Feb  6 21:13:26 2024
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.28.0 (139021)
 Engine:
  Version:          25.0.3
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       f417435
  Built:            Tue Feb  6 21:14:22 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    25.0.3
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.12.1-desktop.4
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.24.6-desktop.1
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container. (Docker Inc.)
    Version:  0.0.24
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-debug
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.0
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.22
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.4
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.0.1
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.5.0
    Path:     /Users/lltedtech/.docker/cli-plugins/docker-scout
WARNING: Plugin "/Users/lltedtech/.docker/cli-plugins/docker-scan" is not valid: failed to fetch metadata: fork/exec /Users/lltedtech/.docker/cli-plugins/docker-scan: no such file or directory

Server:
 Containers: 4
  Running: 4
  Paused: 0
  Stopped: 0
 Images: 4
 Server Version: 25.0.3
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.6.16-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 10
 Total Memory: 7.657GiB
 Name: docker-desktop
 ID: 0bb7b97a-ff9a-46e3-bbb5-9b4cd05eb902
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

WARNING: daemon is not using the default seccomp profile

Diagnostics ID

AC7F73B2-AED1-4DA6-B92C-FB056F5F598C/20240303151759

Additional Info

No response

[colradec]

This issue persists with 4.29.0

[colradec]

Guess, this docker/cli#4963 PR fixes the problem.

[colradec]

fixed but with a factor of approximately 10 slower. Orbstack does the job however.