Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest stable syntax for Dockerfiles #3035

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

thaJeztah
Copy link
Member

I noticed one Dockerfile was pinned to 1.4; given that there's a
backward compatibility guarantee on the stable syntax, the general
recommendation is to use dockerfile:1, which makes sure that the
latest stable release of the Dockerfile syntax is pulled before
building.

While changing, I also made some minor changes to some Dockerfiles
to reduce some unneeded layers.

I noticed one Dockerfile was pinned to 1.4; given that there's a
backward compatibility guarantee on the stable syntax, the general
recommendation is to use `dockerfile:1`, which makes sure that the
latest stable release of the Dockerfile syntax is pulled before
building.

While changing, I also made some minor changes to some Dockerfiles
to reduce some unneeded layers.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah requested a review from milas August 19, 2022 19:07
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milas milas merged commit 1c27ec1 into docker:main Aug 19, 2022
@milas milas added this to the 6.1.0 milestone Aug 19, 2022
@thaJeztah thaJeztah deleted the dockerfile_syntax branch August 19, 2022 19:28
coolguy1771 referenced this pull request in coolguy1771/home-ops Nov 3, 2022
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker](https://github.com/docker/docker-py)
([changelog](https://docker-py.readthedocs.io/en/stable/change-log.html))
| patch | `6.0.0` -> `6.0.1` |

---

### Release Notes

<details>
<summary>docker/docker-py</summary>

### [`v6.0.1`](https://github.com/docker/docker-py/releases/tag/6.0.1)

[Compare
Source](https://github.com/docker/docker-py/compare/6.0.0...6.0.1)

##### 🐛 Bugfixes

- Fix for `The pipe has been ended` errors on Windows
([#&#8203;3056](https://github.com/docker/docker-py/issues/3056))
- Support floats for timestamps in Docker logs (`since` / `until`)
([#&#8203;3031](https://github.com/docker/docker-py/issues/3031))

##### What's Changed

- docs: install package in ReadTheDocs build by
[@&#8203;milas](https://github.com/milas) in
[https://github.com/docker/docker-py/pull/3032](https://github.com/docker/docker-py/pull/3032)
- Use latest stable syntax for Dockerfiles by
[@&#8203;thaJeztah](https://github.com/thaJeztah) in
[https://github.com/docker/docker-py/pull/3035](https://github.com/docker/docker-py/pull/3035)
- feat: add support for floats to docker logs params since / until sinc…
by [@&#8203;ArchiMoebius](https://github.com/ArchiMoebius) in
[https://github.com/docker/docker-py/pull/3031](https://github.com/docker/docker-py/pull/3031)
- Change prune test to use anonymous volumes by
[@&#8203;cpuguy83](https://github.com/cpuguy83) in
[https://github.com/docker/docker-py/pull/3051](https://github.com/docker/docker-py/pull/3051)
- socket: handle npipe close by
[@&#8203;nicks](https://github.com/nicks) in
[https://github.com/docker/docker-py/pull/3056](https://github.com/docker/docker-py/pull/3056)

##### New Contributors

- [@&#8203;ArchiMoebius](https://github.com/ArchiMoebius) made their
first contribution in
[https://github.com/docker/docker-py/pull/3031](https://github.com/docker/docker-py/pull/3031)
- [@&#8203;nicks](https://github.com/nicks) made their first
contribution in
[https://github.com/docker/docker-py/pull/3056](https://github.com/docker/docker-py/pull/3056)

**Full Changelog**:
docker/docker-py@6.0.0...6.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTIuMSJ9-->

Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants