Add swarm support for DataPathPort #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexteradeus
force-pushed
the
data_path_port
branch
2 times, most recently
from
fc1a4da
to
0e00980
Compare
milas
suggested changes
Aug 12, 2022
There was a problem hiding this comment.
Thanks for the PR!
The changes look good, I'm happy to get this merged if you amend your commit to include a DCO sign-off
- Adds support for setting the UDP port used for VXLAN traffic between swarm nodes Signed-off-by: Chris Hand <[email protected]>
dexteradeus
force-pushed
the
data_path_port
branch
from
0e00980
to
7ab7838
Compare
|
Commit amended. Sorry about that. |
milas
approved these changes
Aug 12, 2022
|
Not a problem at all - merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
DataPathPortin much the same way asDataPathAddrwhen initializing a swarm.This option is supported as of api version 1.40:
https://docs.docker.com/engine/api/v1.40/#operation/SwarmInit