Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerignore): trim trailing whitespace #2733

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

kalioz
Copy link
Contributor

@kalioz kalioz commented Dec 21, 2020

Remove the trailing whitespaces in dockerignore files, allowing the following structure to be conform to the official docker build.

*
! files
! src

fixes #2732

@kalioz kalioz force-pushed the fix-dockerignore-trailing-whitespace branch from 6d38ea4 to ab22f08 Compare December 21, 2020 18:09
@kalioz
Copy link
Contributor Author

kalioz commented Dec 21, 2020

Jenkins builds crash because of reasons outside of this PR 😥 I'll try to re-trigger it tomorrow, unless a kind soul can trigger it directly on jenkins without pushing to git :)

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! And you're absolutely correct, our docs do say:

A preprocessing step removes leading and trailing whitespace and eliminates . and .. elements using Go’s filepath.Clean. Lines that are blank after preprocessing are ignored.

(emphasis mine)

@milas milas merged commit 3ee3a24 into docker:main Jul 29, 2022
@milas milas added this to the 6.0.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dockerignore disparity: does not trim spaces
2 participants