Skip to content

Commit

Permalink
deps: upgrade pywin32 & relax version constraint (#3004)
Browse files Browse the repository at this point in the history
Upgrade to latest pywin32, which has support for Python 3.10 and
resolves a CVE (related to ACL APIs, outside the scope of what
`docker-py` relies on, which is npipe support, but still gets
flagged by scanners).

The version constraint has also been relaxed in `setup.py` to allow
newer versions of pywin32. This is similar to how we handle the
other packages there, and should be safe from a compatibility
perspective.

Fixes #2902.
Closes #2972 and closes #2980.

Signed-off-by: Milas Bowman <[email protected]>
  • Loading branch information
milas authored Jul 26, 2022
1 parent e131955 commit a6db044
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ paramiko==2.10.1
pycparser==2.17
pyOpenSSL==18.0.0
pyparsing==2.2.0
pywin32==301; sys_platform == 'win32'
pywin32==304; sys_platform == 'win32'
requests==2.26.0
urllib3==1.26.5
websocket-client==0.56.0
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

extras_require = {
# win32 APIs if on Windows (required for npipe support)
':sys_platform == "win32"': 'pywin32==227',
':sys_platform == "win32"': 'pywin32>=304',

# If using docker-py over TLS, highly recommend this option is
# pip-installed or pinned.
Expand Down

0 comments on commit a6db044

Please sign in to comment.