[master] bump compose version to v2.22.0 #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
force-pushed
the
bump-compose-2.22.0
branch
from
714019a to
5e45297
Compare
neersighted
reviewed
Sep 22, 2023
glours
force-pushed
the
bump-compose-2.22.0
branch
from
5e45297 to
10b66c2
Compare
sam-thibault
previously approved these changes
Sep 24, 2023
Member
|
Copying from Slack: We have legit CI failures here as Compose now requires Go 1.21; this is blocked until either:
Since the second option will likely happen soon (read: days to weeks), @glours expressed he's fine with waiting to get this in. |
glours
force-pushed
the
bump-compose-2.22.0
branch
from
cc23f4a to
c52bb28
Compare
thaJeztah
reviewed
Oct 10, 2023
deb/common/rules
Outdated
| # Build the compose plugin | ||
| cd /go/src/github.com/docker/compose \ | ||
| && make VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build | ||
| && make GO_VERSION=$(GO_VERSION_COMPOSE) VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build |
Member
There was a problem hiding this comment.
This probably won't work, because both deb and rpm build-tools don't / can't use docker; they're plain make targets (but may be running inside a docker container)
glours
force-pushed
the
bump-compose-2.22.0
branch
from
c52bb28 to
b38ea1d
Compare
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
bump-compose-2.22.0
branch
from
b38ea1d to
3e54ed5
Compare
Member
|
oh, LOL, I did a rebase earlier in ca you still wanted to look at a custom option; #953 Let's merge this one |
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/docker/compose/releases/tag/v2.22.0