Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude com.docker.compose.image label from service hash #9214

Merged
merged 1 commit into from
Feb 28, 2022
Merged

exclude com.docker.compose.image label from service hash #9214

merged 1 commit into from
Feb 28, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Feb 28, 2022

What I did
set com.docker.compose.image label as a custom label so it get excluded from config hash computation

Related issue
closes #9211

(not mandatory) A picture of a cute animal, if possible in relation with what you did

glours
glours approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit ec080f1 into docker:v2 Feb 28, 2022
@benedikt-bartscher benedikt-bartscher mentioned this pull request Mar 11, 2022
Closed
@ndeloof ndeloof deleted the inconsistent_hash branch April 7, 2022 11:44
@ndeloof ndeloof mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker config --hash output does not match com.docker.compose.config-hash container label
2 participants
@ndeloof @glours