-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v3.8 schema support #7217
Add v3.8 schema support #7217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compose/const.py
Outdated
@@ -74,4 +76,5 @@ | |||
API_VERSIONS[COMPOSEFILE_V3_5]: '17.06.0', | |||
API_VERSIONS[COMPOSEFILE_V3_6]: '18.02.0', | |||
API_VERSIONS[COMPOSEFILE_V3_7]: '18.06.0', | |||
API_VERSIONS[COMPOSEFILE_V3_8]: '19.03.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as both COMPOSEFILE_V3_7
and COMPOSEFILE_V3_8
== '1.38'
doesn't this override API_VERSIONS['1.28']
just being set to '18.06.0'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but I guess this mapping is more for us to easily view the minimum version needed for each compose file.
compose/const.py
Outdated
@@ -57,6 +58,7 @@ | |||
COMPOSEFILE_V3_5: '1.30', | |||
COMPOSEFILE_V3_6: '1.36', | |||
COMPOSEFILE_V3_7: '1.38', | |||
COMPOSEFILE_V3_8: '1.40', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstand this constant, but afaik 3.8 do not add any new field to require an API upgrade vs 3.7, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I set it back to 1.38. This should be the minimum API version we need for the v3.8 schema.
- service scale bounded by 'max_replicas_per_node' field Signed-off-by: Anca Iordache <[email protected]>
Signed-off-by: Anca Iordache <[email protected]>
Signed-off-by: Anca Iordache <[email protected]>
Signed-off-by: Anca Iordache <[email protected]>
596de14
to
02d8e9e
Compare
Signed-off-by: Anca Iordache <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add v3.8 schema support
Signed-off-by: Anca Iordache [email protected]
Resolves #6530