fix(events): validate service names before subscribing to events - #14076
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
One medium-severity finding was identified in the new E2E test.
Dismissed finding (pre-existing, not introduced by this PR)
cmd/compose/events.go:60— Validation bypass when--project-nameis set without-f: both the oldtoProjectNameand newprojectOrNameskipToProjectin this case, so this is pre-existing behaviour unchanged by the PR.
glours
force-pushed
the
fix/events-validate-service-names
branch
from
August 17, 2026 12:46
94b738d to
e247390
Compare
docker compose events <name> was passing service arguments straight to the event filter without checking they exist in the project, so a typo would produce an event stream matching nothing and block forever with no output and no error. Switch to projectOrName (which validates args via ToProject) before calling backend.Events, consistent with logs, kill, and restart. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
glours
force-pushed
the
fix/events-validate-service-names
branch
from
August 17, 2026 13:09
e247390 to
0acaa66
Compare
Contributor
|
Verified it validates the service now :) $ ./bin/build/docker-compose events typo
# no such service: typo |
ndeloof
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
docker compose events <name>was passing service arguments straight to the event filter without checking they exist in the project, so a typo would produce an event stream matching nothing and block forever with no output and no error.Switch to
projectOrName(which validates args via ToProject) before callingbackend.Events, consistent with logs, kill, and restart.Related issue
JIRA DDB-637
(not mandatory) A picture of a cute animal, if possible in relation to what you did
