refactor: last gocognit candidates — bridge resources and TestViz - #14071
Merged
Conversation
glours
force-pushed
the
refactor-bridge-viz
branch
from
August 18, 2026 08:42
2598187 to
c8a8b5e
Compare
LoadAdditionalResources (cognitive complexity 31) moves its per-service body to loadServiceImageResources, with the local-vs-pull inspection decision in inspectServiceImage. TestViz (35) factors the shared graph assertions into assertVizGraphNodes and assertVizDependencyEdges (t.Helper), merging the allowed/forbidden edge bookkeeping into one equivalent loop. This removes the last two of the 19 //nolint:gocognit suppressions introduced by the gocyclo->gocognit migration: the FIXME debt is fully paid, the linter now runs suppression-free. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
refactor-bridge-viz
branch
from
August 18, 2026 09:41
c8a8b5e to
a1334d4
Compare
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Restructured
LoadAdditionalResources(cognitive complexity 31 → 9) andTestViz(35 → 11, assertion helpers witht.Helper()). This removes the last two of the 19//nolint:gocognitsuppressions from the gocyclo→gocognit migration: the FIXME debt is fully paid, the linter now runs suppression-free across the repo.Related issue
n/a
🤖 Generated with Claude Code